Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring notebook.js #5352

Merged
merged 3 commits into from
May 18, 2020
Merged

Code refactoring notebook.js #5352

merged 3 commits into from
May 18, 2020

Conversation

ErwinRussel
Copy link
Contributor

@ErwinRussel ErwinRussel commented Apr 8, 2020

Refactored duplicate code in notebook.js. Transforming a cell to raw or markdown takes use of a single method.

@ErwinRussel ErwinRussel changed the title [WIP] code refactoring Code refactoring notebook.js Apr 8, 2020
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ErwinRussel

@Zsailer Zsailer merged commit ae7747f into jupyter:master May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants