Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual watch script #4738

Merged
merged 1 commit into from
May 22, 2020
Merged

Add actual watch script #4738

merged 1 commit into from
May 22, 2020

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Jun 27, 2019

Before, the npm run build:watch scripts just re-ran the build every 3 seconds. This uses the onchange npm package to actually watch for changes to the JS or LESS source and run npm run build anytime those changes. I've also added npm run watch script which is more canonical these days.

@blink1073 blink1073 added this to the 6.1 milestone May 22, 2020
blink1073
blink1073 approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnestor!

@blink1073 blink1073 merged commit 7fbbe79 into jupyter:master May 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
component:Server maintenance status:resolved-locked
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnestor @blink1073