Workaround for socket permission errors on Cygwin #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error on Travis appears to be spurious. |
blink1073
force-pushed
the
cygwin/bind-eperm
branch
from
e05a4df
to
7aa6891
Compare
|
Kicking CI. |
|
Oh cool, I forgot about this. Thanks for accepting the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported first here, when running on Cygwin if the notebook server tries to bind on the default port (say 8888) and this results in a permission error for some reason (perhaps a service is installed that as exclusive permission to use that port) the notebook server crashes instead of automatically trying another port.
I confirmed that this is likely due to a bug in Cygwin such that it does not properly map the
WSAEACCESwinsock error code to the POSIXEACCES.This provides a simple workaround--unfortunately the workaround can in principle mask other errors (since the
EPERMset by Cygwin is a default fallback for unrecognized winsock errors), but this is going to be the most likely culprit for users.