Enable restart_kernel for async usage #4412
Conversation
Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts.
|
@minrk - thank you for merging. What is the best way to request a back-port to 5.7.x since it would be ideal if this could be used on Python 2.x (along with its sibling PR jupyter/jupyter_client#425)? I'd be happy to submit a PR on the 5.7.x branch if that's all that is necessary? cc: @takluyver |
This is an "add-on" commit to PR jupyter#4412 in which kernel startup was addressed.
Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts. To take full advantage of async kernel startup (with restarts), this PR along with its "[sibling PR](jupyter/jupyter_client#425)" will be required. Please note, however, that each of these PRs can be independently installed w/o affecting today's notebook applications (as far as I can determine via testing the possible combinations). That said, BOTH of these PRs will be required for usage by Enterprise Gateway - which incurs very long kernel startup times - or other projects that require concurrent kernel starts. It would be ideal to have this PR back-ported to python 2.7-relative release since EG has an immediate need. Signed-off-by: Min RK <benjaminrk@gmail.com>
|
I started backporting it to 5.7.x, but since it's a backward-incompatible API change, that wouldn't be appropriate, so I've marked it for 6.0. |
|
This is really unfortunate. This essentially means that our gateway 1.x line can never support async kernel startup since those customers still require Python 2 which can't coexist with NB 6. Do you know of applications that call |
|
Ah! I misread this PR. |
|
Thanks great news Min - thank you. Do you have a timeframe for the 6.0 releases for NB and JC? We'd like to coordinate our EG 2.0 GA with those if they're in the ballpark of end of March. |
Converted
MappingKernelManager.restart_kernelto a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts. To take full advantage of async kernel startup (with restarts), this PR along with its "sibling PR" will be required.Please note, however, that each of these PRs can be independently installed w/o affecting today's notebook applications (as far as I can determine via testing the possible combinations). That said, BOTH of these PRs will be required for usage by Enterprise Gateway - which incurs very long kernel startup times - or other projects that require concurrent kernel starts.
It would be ideal to have this PR back-ported to python 2.7-relative release since EG has an immediate need.