Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try rebuild translation js #3925

Merged
merged 4 commits into from
Sep 18, 2018
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Sep 15, 2018

Having translations in the core if we don't package them does not make much sens IMHO.

THis is an attempt at fixing that (need to figure out if we should unconditionally depend on Babel to build the SDist on user machine).

@Carreau Carreau added this to the 5.7 milestone Sep 15, 2018
Make sure they are included in sdist/wheel.
@Carreau Carreau force-pushed the package-translations branch 3 times, most recently from 8a43e26 to c53a5cc Compare September 16, 2018 16:24
- no global installation
- invoke with node
@minrk minrk merged commit 33ec644 into jupyter:master Sep 18, 2018
@minrk minrk deleted the package-translations branch September 18, 2018 11:37
@Carreau
Copy link
Member Author

Carreau commented Sep 18, 2018

Thanks !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants