add kernel_info_timeout traitlet for slow kernel start/restart #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpacer
changed the title
|
Now it does this. |
mpacer
changed the title
This affects both the MappingKernelManager and the ZMQChannelsHandler(by extension). This allows one setting to apply to both startup andrestarting.
rgbkrk
reviewed
Jun 6, 2018
| @@ -93,6 +93,22 @@ def _update_root_dir(self, proposal): | |||
| no frontends are connected. | |||
| """ | |||
| ) | |||
|
|
|||
| kernel_info_timeout = Float(60, config=True, | |||
rgbkrk
approved these changes
Jun 6, 2018
mpacer
changed the title
mpacer
changed the title
|
@Carreau @gnestor @takluyver @minrk Are there any issues with this going forward? |
|
Great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to configure how long the notebook waits for a kernel give its
kernel_info_reply.I looked into adding a test, but I think that this would require a good bit of machinery to test properly. I can do that if we want to, but it looks like we're not testing the functionality of most other traitlets directly.
Note: this is not kernel specific… but I don't think we have any way to do kernel specific configuration for the handler as of today.