[WIP] [3335] Convert JS tests to Selenium #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from main jupyter/notebook
This was referenced Apr 22, 2018
|
@takluyver Please review and let me know if anything needs to be improved. |
|
BTW, there's no need to open a new PR when someone requests changes - just push more commits to the same branch, and the PR updates. |
|
Looks good, thanks. |
|
thanks @takluyver , looking forward to contributing more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to contribute to converting JS tests to selenium tests. This patch is for converting notebook/prompt_numbers.js to selenium/test_prompt_numbers.py.
Also removed notebook/prompt_numbers.js
This is a new PR for 3551