Undo patches in teardown before attempting to delete files #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected, that now has only one failure. Now to figure out what causes that. |
|
Hmm, it seems that that fixed it. I was kind of hoping that it wouldn't, because I think that means that something isn't getting cleaned up following a request for a static file, so the file is left 'open'. Tornado devs have told us previously that they don't officially support Windows, so we may have to work around this. But for now this makes tests pass on Appveyor. |
|
Looks good to me, I'm going to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the directory can fail on windows, which leaves the patches in place for other tests which run afterwards. Unfortunately we can't use
addCleanup()with class-level setup/teardown, AFAIK.This will probably still fail at first (unless the original issue is random), but it should see one test failure on Appveyor rather than 5.