Get tests running with tornado 5 #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start asyncio loop explicitly in notebook thread (tornado 4 starts per-thread loops automatically, asyncio doesn’t) - remove unsupported ‘io_loop=‘ arg in websocket test application runs fine with tornado 5, just a few test bits needed updating
to get more warning about upcoming releases that might cause breakages
jcb91
added a commit
to jcb91/jupyter_nbextensions_configurator
that referenced
this pull request
Mar 9, 2018
c.f. notebook jupyter/notebook#3398
takluyver
pushed a commit
that referenced
this pull request
Mar 16, 2018
Get tests running with tornado 5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tornado 5 has just been released. The notebook itself has been updated to work with tornado 5 in the latest releases, but we never ran the tests for this repo with
--predependencies, so the last remaining compatibility fixes which were only in the tests themselves never got caught.Actual fixes:
While at it, update test installation so this should be caught sooner:
--preto get more warning about upcoming releases that might cause breakagescc @blink1073