Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing import _ #3316

Merged
merged 2 commits into from
Feb 8, 2018
Merged

add missing import _ #3316

merged 2 commits into from
Feb 8, 2018

Conversation

ehengao
Copy link

@ehengao ehengao commented Feb 8, 2018

No description provided.

@ehengao
Copy link
Author

ehengao commented Feb 8, 2018

Hope this can merge to the latest version cos code breaked not doing this.

@takluyver
Copy link
Member

This isn't actually broken - the _ gets installed to builtins, so it's available everywhere without needing to import it. But I now think we're better off putting the imports in than forever explaining how it's meant to work.

@takluyver takluyver added this to the 5.5 milestone Feb 8, 2018
@takluyver takluyver merged commit 0db7ef7 into jupyter:master Feb 8, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehengao @takluyver