Alignment issue [FIXED] #3173
Merged
Alignment issue [FIXED] #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not able to figure out why the Travis CI build failed. Can anyone please tell me the reason behind it. |
|
Probably a random failure. I've restarted the job that failed. I'm not that keen on javascript to fix CSS layout issues. Is it possible to do something with CSS calc() instead? |
|
I don't think we can get the same flexibility with CSS calc() as we get from using the 'auto' value in margin. |
blink1073
approved these changes
Jun 3, 2020
|
I think we need to revert this change. It's causing new alignment issues discovered in #5687 that are slightly worse than before. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the alignment issue which was found out to occur in most of the browsers including Chrome and Firefox because of the scroll bar becoming visible and invisible whichever is required.
The main problem this was being caused was because of 'margin-left' property being set to 'auto' as well as the 'overflow' property being set to 'auto'.
So, to fix this issue I updated the 'margin-left' property to align it with the header of the page whenever changes like page reload, resize, etc occurs.
closes #3109