Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use requirejs vs. require #3097

Merged
merged 1 commit into from
Dec 14, 2017
Merged

[WIP] Use requirejs vs. require #3097

merged 1 commit into from
Dec 14, 2017

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Nov 30, 2017 •
edited

Closes #155

@gnestor gnestor mentioned this pull request Nov 30, 2017
Closed
@jasongrout
Copy link
Member

Closes jupyterlab/jupyterlab#3281

Wrong issue?

@gnestor
Copy link
Contributor Author

gnestor commented Dec 1, 2017

Yep, thanks @jasongrout 👌

@gnestor gnestor changed the title Use requirejs vs. require [WIP] Use requirejs vs. require Dec 1, 2017
@takluyver
Copy link
Member

@gnestor is this still a WIP, or do you think it's ready to merge?

@gnestor
Copy link
Contributor Author

gnestor commented Dec 14, 2017

@Carreau @rgbkrk Care to review before we merge?

Here is the merged PR on ipython-contrib: ipython-contrib/jupyter_contrib_nbextensions#1165

rgbkrk
rgbkrk approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good to me, I can't see what might be missed so I think this is fit to ship.

@takluyver takluyver added this to the 5.3 milestone Dec 14, 2017
@takluyver takluyver merged commit ca50f1a into jupyter:master Dec 14, 2017
@takluyver
Copy link
Member

Thanks @rgbkrk

@rgbkrk rgbkrk deleted the requirejs branch December 15, 2017 00:37
@pyup-bot pyup-bot mentioned this pull request Jan 28, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rgbkrk rgbkrk rgbkrk approved these changes

Assignees
No one assigned
Labels
component:Notebook maintenance status:resolved-locked
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

Use "requirejs" instead of "require"
4 participants
@gnestor @jasongrout @takluyver @rgbkrk