Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give Page constructor default arguments #2887

Merged
merged 1 commit into from
Oct 1, 2017
Merged

give Page constructor default arguments #2887

merged 1 commit into from
Oct 1, 2017

Conversation

jcb91
Copy link
Contributor

@jcb91 jcb91 commented Oct 1, 2017

Otherwise, any extension using a template which relied on the old no-parameter formation breaks since #2279

@jcb91
give Page constructor default arguments
9552fc1 
for any extension template which relied on the old no-parameter formation
@jcb91 jcb91 mentioned this pull request Oct 1, 2017
Merged
@rgbkrk rgbkrk merged commit 82c3357 into jupyter:master Oct 1, 2017
@rgbkrk
Copy link
Member

rgbkrk commented Oct 1, 2017

Thanks @jcb91

@takluyver takluyver added this to the 5.2 milestone Oct 3, 2017
@gnestor gnestor modified the milestone: 5.2 Oct 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rgbkrk rgbkrk rgbkrk approved these changes

Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcb91 @rgbkrk @takluyver @gnestor