Factor out output_prompt_function, as is done with input prompt #2774
Conversation
|
Thanks! We're just trying to make a 5.1 release - I've marked this as 5.2 as it's probably not urgent enough to go in at the last minute. Hopefully we can merge it soon after the release. |
| @@ -467,6 +467,11 @@ define([ | |||
| this.element.trigger('changed', {output_area: this}); | |||
| }; | |||
|
|
|||
| OutputArea.output_prompt_classical = function(prompt_value) { | |||
| return '<bdi>'+i18n.msg.sprintf(i18n.msg._('Out[%d]:'),prompt_value)+'</bdi>'; | |||
There was a problem hiding this comment.
Can this construct a node like the old code does, rather than assembling an HTML string? While I don't think there's a security concern here, it's good practice to use the safer style throughout.
There was a problem hiding this comment.
Ok, just made the change. Btw, the code for input_prompt_classical in codecell.js also uses an HTML string, so it might be worth changing that too.
|
@iamlemec This looks good to me. I just re-ran the Travis build and it's passing now. @takluyver Is this ready to merge? |
|
Yup, I think so. @iamlemec thanks, and thanks for checking the input prompt method. If you want to make a separate PR to update that to create an element, I think we could merge that. |
This allows for much cleaner customization of the output prompt in custom.js, as is currently the case with the input prompt.