Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "extraKeys" consistent for notebook and editor #2745

Merged
merged 4 commits into from
Sep 20, 2017
Merged

Make "extraKeys" consistent for notebook and editor #2745

merged 4 commits into from
Sep 20, 2017

Conversation

gnestor
Copy link
Contributor

@gnestor gnestor commented Aug 10, 2017

Closes #2740

@gnestor gnestor added this to the 5.2 milestone Aug 10, 2017
@Carreau
Copy link
Member

Carreau commented Aug 10, 2017

I have no objections to changing the keymap, though that would be inconsistent with the notebook that default to "default" command amp. Would it be better to be consistent and change notebook as well ?

I also would try to get a wider input on if we should change as it may break user habits.

@gnestor
Copy link
Contributor Author

gnestor commented Aug 10, 2017

Would it be better to be consistent and change notebook as well ?

It seems like sublime is the default for the notebook (e.g. if I CMD + / it will comment out a block).

@Carreau
Copy link
Member

Carreau commented Aug 11, 2017

It seems like sublime is the default for the notebook (e.g. if I CMD + / it will comment out a block).

Well no, the default is "default", the Ctrl-/ shortcut is set here

@gnestor
Copy link
Contributor Author

gnestor commented Aug 11, 2017

Ahhh! Ok, we don't need to make sublime the default, I just need to make the notebook and editor extraKeys consistent 👌

@gnestor gnestor changed the title Set "sublime" to default keymap for editor Make "extraKeys" consistent for notebook and editor Aug 11, 2017
takluyver
takluyver reviewed Sep 15, 2017
View reviewed changes
notebook/static/edit/js/editor.js Outdated
"Tab": "indentMore",
"Shift-Tab" : "indentLess",
// "Cmd-Alt-[" : "indentAuto",
// "Ctrl-Alt-[" : "indentAuto",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be in or out? If we don't want them, let's remove them completely rather than commenting them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've removed them from cell.js, but not here ;-)

@takluyver
Copy link
Member

Reopening to rerun tests with master

@takluyver takluyver closed this Sep 20, 2017
@takluyver takluyver reopened this Sep 20, 2017
@takluyver takluyver merged commit 11ba6be into jupyter:master Sep 20, 2017
@gnestor gnestor deleted the keymap-default branch September 20, 2017 15:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takluyver takluyver takluyver left review comments

Assignees
No one assigned
Labels
component:File Editor enhancement status:resolved-locked
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Shortcut Key in File Editor to Block Comment
3 participants
@gnestor @Carreau @takluyver