Expose URL with auth token in notebook UI #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a crude way to copy the link from one browser (right click the Jupyter logo) to get authenticated in another browser. Closes jupytergh-2094
minrk
reviewed
Jul 20, 2017
notebook/templates/page.html
Outdated
| @@ -118,7 +118,7 @@ | |||
|
|
|||
| <div id="header"> | |||
| <div id="header-container" class="container"> | |||
| <div id="ipython_notebook" class="nav navbar-brand pull-left"><a href="{{default_url}}" title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<img src='{{static_url("base/images/logo.png") }}' alt='Jupyter Notebook'/>{% endblock %}</a></div> | |||
| <div id="ipython_notebook" class="nav navbar-brand pull-left"><a href="{{default_url}}?token={{token}}" title='{% trans %}dashboard{% endtrans %}'>{% block logo %}<img src='{{static_url("base/images/logo.png") }}' alt='Jupyter Notebook'/>{% endblock %}</a></div> | |||
There was a problem hiding this comment.
This exposes the login token on the login page, so unauthenticated users can just click this link to login. We should make sure to only include this if the page being served is already authenticated, and only when the token is defined.
There was a problem hiding this comment.
Good job one of us is thinking about this! ;-)
|
Should be fixed now. I'm using the same conditions ( |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a crude way to copy the link from one browser (right click the Jupyter logo) to get authenticated in another browser.
Closes gh-2094