Change favicon when busy #1837
Change favicon when busy #1837
Conversation
|
👍 |
|
I really like this change. Can we also not change the page title anymore, now that we have this much less distracting indicator in a tab? This may be for a different PR, but if you could do it in this PR, that would be awesome. |
|
I'd also favour not changing the title - my tabs are often quite short, and "(Busy)" will take up ~all the visible space. |
|
@jasongrout @takluyver Updated this PR with your suggestion... |
| }); | ||
|
|
||
| this.events.on('kernel_ready.Kernel', function () { | ||
| that.save_widget.update_document_title(); | ||
| $kernel_ind_icon.attr('class','kernel_idle_icon').attr('title','Kernel Idle'); | ||
| knw.info("Kernel ready", 500); | ||
| change_favicon('/static/base/images/favicon.ico'); | ||
| }); | ||
|
|
||
| this.events.on('kernel_idle.Kernel', function () { | ||
| that.save_widget.update_document_title(); |
There was a problem hiding this comment.
We probably don't need this on each kernel idle event now, as we're no longer changing the title on kernel busy.
There was a problem hiding this comment.
I'm not sure I follow... It current changes the favicon to the busy icon on 'kernel_busy.Kernel' and back to normal on 'kernel_idle.Kernel' same for 'kernel_starting.Kernel kernel_created.Session' and 'kernel_ready.Kernel'. If we remove this from kernel idle, then the favicon will indicate that the kernel is busy even after it's idle/done.
There was a problem hiding this comment.
I meant specifically this line that calls update_document_title().
|
I kicked Appveyor. |
|
Appveyor is having constant problems with Python 2 right now, failing with the error "The input line is too long." I don't know what to do about that - I'm ignoring it for now... |
|
Nice! |
|
Is this supposed to work on Safari ? I'm using Version 12.1 (14607.1.40.1.4), enabled favicons in settings>tabs but the icon is stuck on its idle version regardless of kernel state. |
Closes #1820
I’m open to busy icon suggestions…