Fix tests

jupyter · Sep 6, 2022 · 12648b7 · 12648b7
1 parent 1965c5d
commit 12648b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/packages/application/src/shell.ts b/packages/application/src/shell.ts
@@ -180,7 +180,8 @@ export class NotebookShell extends Widget implements JupyterFrontEnd.IShell {
         yield* this._main.widgets;
         return;
       default:
-        throw new Error(`Invalid area: ${area}`);
+        console.error(`This shell has no area called "${area}"`);
+        return;
     }
   }
 

diff --git a/packages/application/test/shell.spec.ts b/packages/application/test/shell.spec.ts
@@ -5,8 +5,6 @@ import { NotebookShell, INotebookShell } from '@jupyter-notebook/application';
 
 import { JupyterFrontEnd } from '@jupyterlab/application';
 
-import { toArray } from '@lumino/algorithm';
-
 import { Widget } from '@lumino/widgets';
 
 describe('Shell', () => {
@@ -31,15 +29,15 @@ describe('Shell', () => {
     it('should add widgets to existing areas', () => {
       const widget = new Widget();
       shell.add(widget, 'main');
-      const widgets = toArray(shell.widgets('main'));
+      const widgets = Array.from(shell.widgets('main'));
       expect(widgets).toEqual([widget]);
     });
 
-    it('should throw an exception if the area does not exist', () => {
+    it('should be empty and console.error if area does not exist', () => {
+      const spy = jest.spyOn(console, 'error');
       const jupyterFrontEndShell = shell as JupyterFrontEnd.IShell;
-      expect(() => {
-        jupyterFrontEndShell.widgets('left');
-      }).toThrow('Invalid area: left');
+      expect(Array.from(jupyterFrontEndShell.widgets('left'))).toHaveLength(0);
+      expect(spy).toHaveBeenCalled();
     });
   });
 
@@ -62,15 +60,15 @@ describe('Shell', () => {
       const widget = new Widget();
       widget.id = 'foo';
       shell.add(widget, 'top');
-      const widgets = toArray(shell.widgets('top'));
+      const widgets = Array.from(shell.widgets('top'));
       expect(widgets.length).toBeGreaterThan(0);
     });
 
     it('should accept options', () => {
       const widget = new Widget();
       widget.id = 'foo';
       shell.add(widget, 'top', { rank: 10 });
-      const widgets = toArray(shell.widgets('top'));
+      const widgets = Array.from(shell.widgets('top'));
       expect(widgets.length).toBeGreaterThan(0);
     });
   });
@@ -80,7 +78,7 @@ describe('Shell', () => {
       const widget = new Widget();
       widget.id = 'foo';
       shell.add(widget, 'main');
-      const widgets = toArray(shell.widgets('main'));
+      const widgets = Array.from(shell.widgets('main'));
       expect(widgets.length).toBeGreaterThan(0);
     });
   });