fix: pasting outside of cells doing nothing #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously pasting anything but cells into the notebook would do nothing. This way pasting other content uses the browser's default action.
|
Hi @krassowski , I guess these failures are unrelated. If not, let us know and we can take a look. Cheers, Maarten |
|
@RRosio maybe you'd like to take a look. It's a small, almost trivial fix, we only needed to prevent default on cell pasting. |
|
Thank you for the ping @maartenbreddels! I can go ahead and merge this! I will also take a look at preparing to make a release early next week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pasting anything but cells into the notebook would do nothing. This way pasting other content uses the browser's default action.
Fixes #284
Fixes widgetti/solara#671