Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating of .mo and .json files for nl translation #221

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix generating of .mo and .json files for nl translation #221

merged 1 commit into from
Feb 23, 2023

Conversation

frenzymadness
Copy link
Contributor

The previous glob pattern "??_??" does not match /nl/.

Before:

$ unzip -l dist/nbclassic-0.6.0.dev0-py3-none-any.whl | grep "i18n/nl/"
    19908  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbclassic.po
    66784  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbjs.po
    19825  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbui.po

$ tar -tf dist/nbclassic-0.6.0.dev0.tar.gz | grep "i18n/nl/"
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbclassic.po
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbjs.po
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbui.po

After:

$ unzip -l dist/nbclassic-0.6.0.dev0-py3-none-any.whl | grep "i18n/nl/"
    15500  02-21-2023 09:29   nbclassic/i18n/nl/LC_MESSAGES/nbclassic.mo
    19908  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbclassic.po
    48832  02-21-2023 09:28   nbclassic/i18n/nl/LC_MESSAGES/nbjs.json
    66784  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbjs.po
    11803  02-21-2023 09:29   nbclassic/i18n/nl/LC_MESSAGES/nbui.mo
    19825  02-21-2023 07:52   nbclassic/i18n/nl/LC_MESSAGES/nbui.po

$ tar -tf dist/nbclassic-0.6.0.dev0.tar.gz | grep "i18n/nl/"
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbclassic.mo
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbclassic.po
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbjs.json
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbjs.po
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbui.mo
nbclassic-0.6.0.dev0/nbclassic/i18n/nl/LC_MESSAGES/nbui.po

@frenzymadness
Fix generating of .mo and .json files for nl translation
97b2aca 
The previous glob pattern "??_??" does not match /nl/.
@RRosio RRosio added the bug Something isn't working label Feb 23, 2023
@RRosio
Copy link
Collaborator

RRosio commented Feb 23, 2023

This looks great, thank you @frenzymadness!

@RRosio RRosio merged commit 92bb8c5 into jupyter:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frenzymadness @RRosio