Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate notebook_shim from setup.cfg #197

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

frenzymadness
Copy link
Contributor

No description provided.

@RRosio RRosio added dependencies Pull requests that update a dependency file maintenance labels Jan 20, 2023
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @frenzymadness

@echarles echarles merged commit 4de7761 into jupyter:main Jan 20, 2023
@echarles
Copy link
Member

@frenzymadness I am double checking this merged changes and see that setup.py has been added in the exclude section. Was that intended? Any unexpected impact?

@frenzymadness
Copy link
Contributor Author

@frenzymadness I am double checking this merged changes and see that setup.py has been added in the exclude section. Was that intended? Any unexpected impact?

setup.py was there before. The change is just a new line added at the end of the file by the web editor. See the icon at the left side of the diff.

image

@frenzymadness frenzymadness deleted the patch-1 branch January 23, 2023 08:05
@echarles
Copy link
Member

Sound good. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants