Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright Testing Conversion #170

Merged
merged 199 commits into from
Oct 22, 2022
Merged

Playwright Testing Conversion #170

merged 199 commits into from
Oct 22, 2022

Conversation

ericsnekbytes
Copy link
Collaborator

@ericsnekbytes ericsnekbytes commented Oct 21, 2022 •
edited

Converts frontend testing to a new/refactored framework based on playwright, and removes the old selenium tests.

  • Tests are now at nbclassic/tests/end_to_end
  • The utility layer and public testing framework, based on playwright, is contained utils.py
    • NotebookFrontend
    • FrontendElement
  • Pytest fixtures for obtaining browser instances, the jupyter server etc, are contained in conftest.py
  • Some minor issues with flakiness remain, but at present this is a substantial improvement over the old selenium tests

@ericsnekbytes
Initial skeleton subpackage.
5943cc9
@ericsnekbytes
Initial WIP playwright test skeleton.
455d5a8
@ericsnekbytes
WIP util edits.
7c00171
@ericsnekbytes
Added refactors from team session.
d30b82e
@ericsnekbytes
WIP NotebookFrontend refactor
09437c5
@ericsnekbytes
WIP working test in debug mode.
8bb241b
@ericsnekbytes
WIP working in debug mode, fix editor_page wait.
1a04366
@ericsnekbytes
Working (ROUGH) POC test (todo remove explicit waits).
269fd61
@ericsnekbytes
Cleanup.
8f43e49
@ericsnekbytes
Added checks for frontend objects.
88bf45b
@ericsnekbytes
Added wait method.
4765a49
@ericsnekbytes
Added more test logic.
e1abe46
@ericsnekbytes
Added more test logic.
a3f7a88
@ericsnekbytes
Finished adding test logic, fixed wait_for_cell_output index bug
055c803
@ericsnekbytes
Small refactors/cleanup, disabled not-yet-used logic.
7372e9f
@ericsnekbytes
More code cleanup.
2bc8127
@ericsnekbytes
Replaced cmdtrl func with encapsulated mod key method.
099a103
@ericsnekbytes
Cell output wait logic fix.
3a1d6ee
@ericsnekbytes
Added WIP test_deletecell and related utils updates.
be816bb
@ericsnekbytes
Renaming.
5b58524
@ericsnekbytes
Test/framework updates.
8372360
@ericsnekbytes
Test updates.
a53cf8e
@ericsnekbytes
Test updates.
e1de729
@ericsnekbytes
Finished test_delete_cells()
d32d052
@ericsnekbytes
Finished test_interrupt()
b5bc971
@ericsnekbytes
Minor cleanup.
7f72539
@ericsnekbytes
Added test prototyper docs.
ee196f4
@ericsnekbytes
Revised docstring.
61b155e
@ericsnekbytes
Fixed JS evaluate call in get_cell_contents()
ba8d2b7
@ericsnekbytes
Updated cell data return format.
a6a730e
ericsnekbytes and others added 21 commits October 18, 2022 11:40
@ericsnekbytes
Combine single test runs into one step
770b14b
@RRosio
testing full test suit runs jupyter#1
e225f09
@RRosio
macos dbg2
05526c4
@ericsnekbytes
Added state checks at various points in the test.
14f04c9
@ericsnekbytes
Merge branch 'pw_refactor_test_exec_code2' into playwright_conversion
1df58f5
@ericsnekbytes
Added extra checks for cell output.
e8f16dc
@RRosio
update save_readonly_as
81da4b6
@RRosio
Merge branch 'pw_dbg1' into playwright_conversion
fa3d098
@ericsnekbytes
Merge branch 'pw_refactor_test_exec_code2' into playwright_conversion
16c4162
@ericsnekbytes
Refactor find/replace to use .value in eval call.
e264193
@ericsnekbytes
Merge branch 'pw_refactor_find_rep2' into playwright_conversion
d5ee6a4
@ericsnekbytes
Added retry to browser fixture
103f5ca
@ericsnekbytes
Removed wait from locate and focus method.
146b072
@ericsnekbytes
Temp workflow edits for debugging (add workflows back later)
94be604
@ericsnekbytes
Fixed temp workflow run files.
2ac94b8
@ericsnekbytes
Fixed temp workflow edits.
b8a909d
@ericsnekbytes
Temp workflow edits
b5cf67a
@ericsnekbytes
More workflow edits.
d677d66
@ericsnekbytes
Revised timeout on test_kernel_menu, WIP workflow edits.
d3bcdc2
@ericsnekbytes
Updated workflow files and the test prototyper.
3525185
@ericsnekbytes
Removed selenium tests.
e668ffd
@echarles echarles added the enhancement New feature or request label Oct 21, 2022
@ericsnekbytes ericsnekbytes changed the title DRAFT Playwright Testing Conversion Playwright Testing Conversion Oct 21, 2022
@ericsnekbytes ericsnekbytes marked this pull request as ready for review October 21, 2022 18:42
echarles
echarles approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM!

@echarles echarles merged commit cab2ea5 into jupyter:main Oct 22, 2022
@jtpio jtpio mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericsnekbytes @echarles @RRosio