Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a redirect from /nbclassic to /nbclassic/tree if both notebook>=7 if both notebook>=7 and nbclassic are installed #166

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add a redirect from /nbclassic to /nbclassic/tree if both notebook>=7 if both notebook>=7 and nbclassic are installed #166

merged 2 commits into from
Oct 18, 2022

Conversation

echarles
Copy link
Member

Fixes #163

@echarles echarles mentioned this pull request Oct 17, 2022
Closed
@echarles echarles added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 17, 2022
mcrutch
mcrutch reviewed Oct 17, 2022
View reviewed changes
nbclassic/notebookapp.py Outdated Show resolved Hide resolved
@echarles
Copy link
Member Author

@mcrutch this is ready for review

@RRosio
Copy link
Collaborator

RRosio commented Oct 18, 2022

LGTM! Thank you both @echarles and @mcrutch!

@RRosio RRosio merged commit 7e55b21 into jupyter:main Oct 18, 2022
@echarles echarles mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcrutch mcrutch mcrutch left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/nbclassic/ should redirect to /nbclassic/tree
3 participants
@echarles @RRosio @mcrutch