Skip to content

Commit

Permalink
Merge pull request #131 from datalayer-externals/fix/check-release-de…
Browse files Browse the repository at this point in the history
…v-version

Fix handling of dev version when releasing
  • Loading branch information
echarles committed Jul 11, 2022
2 parents 7ea5af3 + 4caff48 commit 9dc59f9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
if: ${{ matrix.group == 'check_release' }}
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v1
with:
version_spec: 100.100.100
token: ${{ secrets.GITHUB_TOKEN }}
- name: Run Link Check
if: ${{ matrix.group == 'link_check' }}
Expand Down
11 changes: 11 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
# Making a NbClassic Release

## Using `jupyter_releaser`

The recommended way to make a release is to use [`jupyter_releaser`](https://github.com/jupyter-server/jupyter_releaser#checklist-for-adoption).

Note that we must use manual versions since Jupyter Releaser does not
yet support "next" or "patch" when dev versions are used.

## Manual Release

To create a release, update the version number in `nbclassic/__version__.py`, then run the following:

```
Expand Down

0 comments on commit 9dc59f9

Please sign in to comment.