Add position to Maps add method #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Dec 14, 2023
ipyleaflet/leaflet.py
Outdated
| @@ -2676,13 +2676,15 @@ def __isub__(self, item): | |||
| def __add__(self, item): | |||
| return self.add(item) | |||
|
|
|||
| def add(self, item): | |||
| def add(self, item, position=None): | |||
There was a problem hiding this comment.
Suggested change
| def add(self, item, position=None): | |
| def add(self, item, index=None): |
|
I added the UI tests, I also added the collapsed option to the LayerControl since that was easier then getting playwright to hover the mouse and take a screenshot |
You probably forgot to commit the files for that? Only |
lol woops |
|
update galata references |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
positionparameter to Mapsaddmethod, allowing users to specify where in the layers stack they would add their new layer.