Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix CSS issue #1154

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

gjmooney
Copy link
Contributor

Fix for the bug mentioned in #1578

@martinRenou martinRenou changed the title Fix css issue Documentation: Fix CSS issue Dec 11, 2023
@martinRenou
Copy link
Member

Thanks! It seems to have fixed properly the Image Overlay docs

image

There is still an issue with the icon though: https://ipyleaflet--1154.org.readthedocs.build/en/1154/layers/icon.html (there should not be a background on the marker)

@gjmooney
Copy link
Contributor Author

The new changes should make markers and icons display correctly as well.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@martinRenou martinRenou merged commit 1b37189 into jupyter-widgets:master Dec 12, 2023
4 checks passed
@gjmooney gjmooney deleted the fix_css_issue branch December 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants