-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subitems to layers (either layers or controls or a mixture of both) #1011
Add subitems to layers (either layers or controls or a mixture of both) #1011
Conversation
a8cdd1d
to
3cb5d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase on master?
e75220b
to
afd2370
Compare
Thanks for the review. Rebase has been made. |
38dfc81
to
1aa9b8f
Compare
e514e31
to
3bfa4c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add a galata test for this :)
A notebook has been added in ui-tests/notebooks in e0b19ac, to test adding subitems in layers and check that they correctly display. |
please update galata references |
Please update galata reference |
8f1ecfa
to
6fe5c64
Compare
please update galata references |
daebc35
to
b077f75
Compare
please update galata references |
The CI tests are now green. Is there other things I may add or check ? |
Thanks! I will give the PR a try. I suspect there is a bug when you create the map in a first Notebook cell, and add the layers with sub-layers in a separate cell. |
Indeed there is an issue when the Map is shown before adding the layers with sub-items, as seen in this screenshot (the first map view does not have the subitems visible, the second map view has them): |
b442492
to
dd8dce0
Compare
63bfb8c
to
6f2aeb1
Compare
please update galata references |
1 similar comment
please update galata references |
…eIcon subitem, in ui-tests/notebooks/Subitems.ipynb.
…s at the scale of the layer.
Co-authored-by: martinRenou <martin.renou@gmail.com>
…he failing rendering widgets test.
3b15ce7
to
c52fc55
Compare
please update galata references |
1 similar comment
please update galata references |
please update galata references |
Please update galata references, this time it should probably work :D |
235c73b
to
6e102e8
Compare
update galata references |
Triggering CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
Thanks a lot for the review and help on this PR ! |
Add subitems to layers (either layers or controls or a mixture of both).