Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nudge on the control channel instead of the shell #628

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

JohanMabille
Copy link
Contributor

@JohanMabille JohanMabille commented Dec 3, 2021

Fixes #622.

Notice that we do not need to wait for this JEP to be accepted before merging this PR, since the current specification of the protocol does not prevent sending kernel_info requests on the control channel.

@codecov-commenter
Copy link

Codecov Report

Merging #628 (383dfae) into master (e5cb6c4) will decrease coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   77.63%   77.56%   -0.07%     
==========================================
  Files         110      110              
  Lines       10398    10393       -5     
  Branches     1408     1407       -1     
==========================================
- Hits         8072     8061      -11     
- Misses       1929     1933       +4     
- Partials      397      399       +2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 60.40% <71.42%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cb6c4...383dfae. Read the comment docs.

@Zsailer Zsailer added the bug label Dec 3, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New websocket unable to communicate with kernel paused in debugging
4 participants