Prefer LightRenderer on Windows if it's available

Fix #1766
junegunn · Oct 30, 2020 · 7915e36 · 7915e36
1 parent 1c68f81
commit 7915e36
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/src/terminal.go b/src/terminal.go
@@ -408,11 +408,11 @@ func NewTerminal(opts *Options, eventBox *util.EventBox) *Terminal {
 	var renderer tui.Renderer
 	fullscreen := opts.Height.size == 0 || opts.Height.percent && opts.Height.size == 100
 	if fullscreen {
-		if tui.HasFullscreenRenderer() {
-			renderer = tui.NewFullscreenRenderer(opts.Theme, opts.Black, opts.Mouse)
-		} else {
+		if tui.IsLightRendererSupported() {
 			renderer = tui.NewLightRenderer(opts.Theme, opts.Black, opts.Mouse, opts.Tabstop, opts.ClearOnExit,
 				true, func(h int) int { return h })
+		} else {
+			renderer = tui.NewFullscreenRenderer(opts.Theme, opts.Black, opts.Mouse)
 		}
 	} else {
 		maxHeightFunc := func(termHeight int) int {

diff --git a/src/tui/dummy.go b/src/tui/dummy.go
@@ -6,10 +6,6 @@ package tui
 
 type Attr int
 
-func HasFullscreenRenderer() bool {
-	return false
-}
-
 func (a Attr) Merge(b Attr) Attr {
 	return a | b
 }

diff --git a/src/tui/tcell.go b/src/tui/tcell.go
@@ -15,10 +15,6 @@ import (
 	"github.com/mattn/go-runewidth"
 )
 
-func HasFullscreenRenderer() bool {
-	return true
-}
-
 func (p ColorPair) style() tcell.Style {
 	style := tcell.StyleDefault
 	return style.Foreground(tcell.Color(p.Fg())).Background(tcell.Color(p.Bg()))