prefer &shell to git bash on windows even if available #1547
Conversation
calling git bash via cmd on windows is slow and opens a popup window
| @@ -163,7 +163,7 @@ function! fzf#vim#with_preview(...) | |||
| call remove(args, 0) | |||
| endif | |||
|
|
|||
| if !executable(s:bash()) | |||
| if (has('win32') && &shell !~? '\v<(ba)?sh>') || !executable(s:bash()) | |||
There was a problem hiding this comment.
What exactly does this supposed to do?
The original condition checks if a bash is available, and if not, does not add preview options.
So you don't want preview window to appear? Is the title of the PR correct?
There was a problem hiding this comment.
In Windows, if my shell is not bash, but say cmd as is the default in Win32 Vim, then I prefer not to have a cmd window popping up that calls Git Bash that in turn calls fzf showing something like
C:\WINDOWS\system32\cmd.exe /c (^(C:\PROGRA~1\Git\bin\bash.exe -c ^"ls /mnt/[A-Za-z]^"^) ^>C:\Users\Konfekt\AppData\Local\Temp\VBVAC39.tmp 2^>^&1)
even though Git Bash is installed (which is what executable(s:bash()) checks).
Instead, call fzf directly.
The former is what's currently happening if Git Bash is installed an fzf#vim#with_preview(...) run, say in https://github.com/mg979/vim-mini-plugins/blob/master/plugin/mru.vim
There was a problem hiding this comment.
Can you show me some screenshots before/after the patch?
calling git bash via cmd on windows is slow and opens a popup window