This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Always retry connections to NATS #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NATS connections created by the filter and monitor weren't set to keep retrying and were using the default reconnection limit of 60. The listener and writer were using infinite NATS reconnection attempts but were setting this up in an undocumented way (which may not always have worked).
|
@oplehto I wonder if this could have been the cause for data not flowing in one case that you saw recently? |
|
This is certainly possible. I am planning to do comprehensive testing of all the component failure scenarios in our k8s qa environment and their effect on the traffic flow to see if everything holds up. |
oplehto
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NATS connections created by the filter and monitor weren't set to keep retrying and were using the default reconnection limit of 60.
The listener and writer were using infinite NATS reconnection attempts but were setting this up in an undocumented way (which may not always have worked).