Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

New writer max_pending metric #65

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Conversation

mjs
Copy link
Contributor

@mjs mjs commented Apr 17, 2018

This metric reports the maximum number of pending bytes observed across all a writer's NATS subscriptions. This can be used to help tune the nats_pending_max_mb configuration option.

To assist with generating this metric stats.Stats now supports tracking of maximum values.

Closes #31.

mjs added 3 commits April 17, 2018 16:47
This metric is the maximum number of bytes have been pending on any
the writer's NATS subscriptions.
Given the value of the metric is hard to know up front, regex matching
is used.
@mjs mjs requested a review from oplehto April 17, 2018 05:11
Copy link
Contributor

@oplehto oplehto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oplehto oplehto merged commit 840e8da into jumptrading:master Apr 20, 2018
@mjs mjs deleted the writer-maxpending branch June 26, 2018 02:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants