Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing bug in copy_to #101

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix indexing bug in copy_to #101

merged 3 commits into from
Oct 27, 2020

Conversation

odow
Copy link
Member

@odow odow commented Oct 26, 2020

Closes #100.

I don't really understand how Clp was passing tests without this. I need to look into it more. There are no tests in contlinear which check the dual solutions when there are two constraints of the same sense.

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   64.51%   64.51%           
=======================================
  Files           3        3           
  Lines         465      465           
=======================================
  Hits          300      300           
  Misses        165      165           
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 87.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9012c3f...94a9f36. Read the comment docs.

@odow odow merged commit 0f30c44 into master Oct 27, 2020
@odow odow deleted the od/bug branch October 27, 2020 19:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

copy_to incorrectly maps scalar constraints
2 participants