Merge branch 'WerWolv:master' into master

jumanji144 · Aug 3, 2024 · 6a70396 · 6a70396
2 parents 294668b + e726fce
commit 6a70396
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/lib/external/pattern_language b/lib/external/pattern_language
diff --git a/lib/libimhex/source/api/imhex_api.cpp b/lib/libimhex/source/api/imhex_api.cpp
@@ -337,8 +337,11 @@ namespace hex {
         }
 
         void markDirty() {
-            get()->markDirty();
-            EventProviderDirtied::post(get());
+            const auto provider = get();
+            if (!provider->isDirty()) {
+                provider->markDirty();
+                EventProviderDirtied::post(provider);
+            }
         }
 
         void resetDirty() {

diff --git a/plugins/builtin/include/content/views/view_pattern_editor.hpp b/plugins/builtin/include/content/views/view_pattern_editor.hpp
@@ -190,6 +190,7 @@ namespace hex::plugin::builtin {
         std::atomic<u32> m_runningParsers    = 0;
 
         bool m_hasUnevaluatedChanges = false;
+        std::chrono::time_point<std::chrono::steady_clock> m_lastEditorChangeTime;
 
         TextEditor m_textEditor, m_consoleEditor;
         std::atomic<bool> m_consoleNeedsUpdate = false;

diff --git a/plugins/builtin/source/content/views/view_pattern_editor.cpp b/plugins/builtin/source/content/views/view_pattern_editor.cpp
@@ -549,21 +549,24 @@ namespace hex::plugin::builtin {
 
             if (m_textEditor.IsTextChanged()) {
                 m_hasUnevaluatedChanges = true;
+                m_lastEditorChangeTime = std::chrono::steady_clock::now();
                 ImHexApi::Provider::markDirty();
             }
 
             if (m_hasUnevaluatedChanges && m_runningEvaluators == 0 && m_runningParsers == 0) {
-                m_hasUnevaluatedChanges = false;
+                if ((std::chrono::steady_clock::now() - m_lastEditorChangeTime) > std::chrono::seconds(1)) {
+                    m_hasUnevaluatedChanges = false;
 
-                const auto &code = m_textEditor.GetText();
-                EventPatternEditorChanged::post(code);
+                    auto code = m_textEditor.GetText();
+                    EventPatternEditorChanged::post(code);
 
-                TaskManager::createBackgroundTask("hex.builtin.task.parsing_pattern"_lang, [this, code, provider](auto &){
-                    this->parsePattern(code, provider);
+                    TaskManager::createBackgroundTask("hex.builtin.task.parsing_pattern"_lang, [this, code = std::move(code), provider](auto &){
+                        this->parsePattern(code, provider);
 
-                    if (m_runAutomatically)
-                        m_triggerAutoEvaluate = true;
-                });
+                        if (m_runAutomatically)
+                            m_triggerAutoEvaluate = true;
+                    });
+                }
             }
 
             if (m_triggerAutoEvaluate.exchange(false)) {