Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes #495

Merged
merged 1 commit into from
Sep 10, 2024
Merged

misc fixes #495

merged 1 commit into from
Sep 10, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 10, 2024

🚀 This description was created by Ellipsis for commit 2e1bb65

Summary:

This pull request adjusts timeout values in several workflow execution functions, comments out certain transition validations, and introduces a new YAML example for a reclaim task.

Key points:

  • agents-api/agents_api/models/execution/create_execution_transition.py: Commented out validation checks for transition types "finish", "finish_branch", "error", "cancelled".
  • agents-api/agents_api/web.py: Added protocol import from env.
  • agents-api/agents_api/workflows/task_execution/__init__.py: Increased schedule_to_close_timeout from 3 to 30 seconds for debug/testing.
  • agents-api/agents_api/workflows/task_execution/helpers.py: Increased schedule_to_close_timeout from 2 and 5 to 30 seconds.
  • agents-api/agents_api/workflows/task_execution/transition.py: Increased schedule_to_close_timeout from 2 to 30 seconds.
  • reclaim-example.yaml: Added a new YAML file as an example of a reclaim task with input schema and task instructions.

Generated with ❤️ by ellipsis.dev

Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2e1bb65 in 21 seconds

More details
  • Looked at 186 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. agents-api/agents_api/models/execution/create_execution_transition.py:29
  • Draft comment:
    Remove commented-out code if not needed to keep the codebase clean.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The commented-out code in validate_transition_targets function should be removed if not needed, as it clutters the codebase.
2. agents-api/agents_api/web.py:22
  • Draft comment:
    Remove unused import protocol to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The protocol variable is imported but not used in web.py. This is unnecessary and should be removed to clean up the code.
3. agents-api/agents_api/workflows/task_execution/__init__.py:199
  • Draft comment:
    Verify the impact of changing schedule_to_close_timeout from 3 to 30 seconds for debug/testing on performance and functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The timeout for schedule_to_close_timeout in run function has been changed from 3 to 30 seconds for debug or testing. This change should be verified for its impact on performance and functionality.
4. agents-api/agents_api/workflows/task_execution/helpers.py:171
  • Draft comment:
    Verify the impact of changing schedule_to_close_timeout from 2 to 30 seconds on performance and functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The timeout for schedule_to_close_timeout in execute_map_reduce_step has been increased from 2 to 30 seconds. This change should be reviewed for its impact on performance and functionality.
5. agents-api/agents_api/workflows/task_execution/helpers.py:246
  • Draft comment:
    Verify the impact of changing schedule_to_close_timeout from 5 to 30 seconds on performance and functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The timeout for schedule_to_close_timeout in execute_map_reduce_step_parallel has been increased from 5 to 30 seconds. This change should be reviewed for its impact on performance and functionality.
6. agents-api/agents_api/workflows/task_execution/transition.py:47
  • Draft comment:
    Verify the impact of changing schedule_to_close_timeout from 2 to 30 seconds on performance and functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The timeout for schedule_to_close_timeout in transition function has been increased from 2 to 30 seconds. This change should be reviewed for its impact on performance and functionality.

Workflow ID: wflow_KL0GaYvQNDwMuwCd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr changed the title wip misc fixes Sep 10, 2024
@creatorrr creatorrr merged commit 32793b0 into dev Sep 10, 2024
5 of 8 checks passed
@creatorrr creatorrr deleted the f/haidar-session branch September 10, 2024 16:55
@creatorrr creatorrr restored the f/haidar-session branch September 10, 2024 16:55
@creatorrr creatorrr deleted the f/haidar-session branch September 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant