text-embeddings-inference-cpu temp fix for Apple Silicon CPUs #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://github.com/avatars/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 37922d1 in 5 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/docker-compose.yml:105
- Draft comment:
Consider documenting this temporary fix in a more permanent location, such as a README or a comment in the codebase, to ensure future developers are aware of the reason for this change and can address it if necessary. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the platform specification is a temporary fix for compatibility with Mac M-series chips. This is a valid change given the context provided in the PR description.
Workflow ID: wflow_kktqaWDf43axfQKA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
creatorrr
deleted the
x/fix-text-embeddings-inference-cpu-mac-m-series
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
linux/amd64platform totext-embeddings-inference-cpuservice inagents_api/agents-api/docker-compose.yml.Summary:
Added
platform: linux/amd64totext-embeddings-inference-cpuinagents-api/docker-compose.ymlto fix compatibility with Mac M-series CPUs.Key points:
platform: linux/amd64totext-embeddings-inference-cpuservice inagents-api/docker-compose.yml.Generated with ❤️ by ellipsis.dev