feat: unblock and forward buttons properly #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenesvk
added a commit
to eugenesvk/kanata
that referenced
this pull request
Apr 27, 2024
Closes jtroo#968. For now there is no way to block mouse buttons that are being forwarded to kanata. If someone requests it or opens a PR, the feature may be included, but for now I don't see a reason why it's necessary. It seems much more sensible for someone to want to block their unused keyboard buttons to force the learning of new typing habits compared to blocking mouse buttons for a similar reason.
eugenesvk
added a commit
to eugenesvk/kanata
that referenced
this pull request
Apr 28, 2024
Closes jtroo#968. For now there is no way to block mouse buttons that are being forwarded to kanata. If someone requests it or opens a PR, the feature may be included, but for now I don't see a reason why it's necessary. It seems much more sensible for someone to want to block their unused keyboard buttons to force the learning of new typing habits compared to blocking mouse buttons for a similar reason.
eugenesvk
added a commit
to eugenesvk/kanata
that referenced
this pull request
Apr 28, 2024
Closes jtroo#968. For now there is no way to block mouse buttons that are being forwarded to kanata. If someone requests it or opens a PR, the feature may be included, but for now I don't see a reason why it's necessary. It seems much more sensible for someone to want to block their unused keyboard buttons to force the learning of new typing habits compared to blocking mouse buttons for a similar reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Closes #968. For now there is no way to block mouse buttons that are being forwarded to kanata. If someone requests it or opens a PR, the feature may be included, but for now I don't see a reason why it's necessary. It seems much more sensible for someone to want to block their unused keyboard buttons to force the learning of new typing habits compared to blocking mouse buttons for a similar reason.
Checklist