Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] extract type parameters to a variable #3634

Conversation

HenryBrown0
Copy link
Contributor

First of a two part pr to transition to typeArguments and fallback to typeParameters for @typescript-eslint v6.

This pr extracts type parameters to a variable before being used.

Second part can be found: #3629

HenryBrown0 and others added 4 commits September 24, 2023 13:30
Co-authored-by: HenryBrown0 <26250092+HenryBrown0@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: HenryBrown0 <26250092+HenryBrown0@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #3634 (b4199ac) into master (41d9b61) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head b4199ac differs from pull request most recent head ca30f77. Consider uploading reports for the commit ca30f77 to get more accurate results

@@            Coverage Diff             @@
##           master    #3634      +/-   ##
==========================================
+ Coverage   97.47%   97.65%   +0.17%     
==========================================
  Files         132      132              
  Lines        9360     9369       +9     
  Branches     3427     3429       +2     
==========================================
+ Hits         9124     9149      +25     
+ Misses        236      220      -16     
Files Coverage Δ
lib/rules/boolean-prop-naming.js 99.40% <100.00%> (+0.01%) ⬆️
lib/rules/function-component-definition.js 99.00% <100.00%> (ø)
lib/rules/jsx-props-no-multi-spaces.js 100.00% <100.00%> (ø)
lib/util/propTypes.js 97.44% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@HenryBrown0 HenryBrown0 marked this pull request as ready for review September 24, 2023 14:59
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall :-) just a few small tweaks and i'll land this, and you can rebase the other one.

lib/rules/boolean-prop-naming.js Outdated Show resolved Hide resolved
lib/rules/function-component-definition.js Outdated Show resolved Hide resolved
lib/rules/function-component-definition.js Outdated Show resolved Hide resolved
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same throughout about uncovered lines

lib/rules/jsx-props-no-multi-spaces.js Show resolved Hide resolved
lib/util/propTypes.js Show resolved Hide resolved
@ljharb ljharb marked this pull request as draft October 9, 2023 20:14
@ljharb ljharb force-pushed the refactor/extract-node-type-parameters-to-var branch from b4199ac to d08f761 Compare November 3, 2023 18:02
@ljharb ljharb marked this pull request as ready for review November 3, 2023 18:09
@ljharb ljharb force-pushed the refactor/extract-node-type-parameters-to-var branch from d08f761 to ca30f77 Compare November 3, 2023 22:30
@ljharb ljharb changed the title [Refactor]: extract type parameters to a variable [Refactor] extract type parameters to a variable Nov 3, 2023
@ljharb ljharb merged commit ca30f77 into jsx-eslint:master Nov 4, 2023
312 checks passed
@HenryBrown0 HenryBrown0 deleted the refactor/extract-node-type-parameters-to-var branch November 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants