-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] support eslint 8.x #3059
[New] support eslint 8.x #3059
Conversation
Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3059 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 118 118
Lines 7914 7914
Branches 2833 2833
=======================================
Hits 7718 7718
Misses 196 196
Continue to review full report at Codecov.
|
a06affd
to
ca20fe6
Compare
994b829
to
47e58c8
Compare
7a901f2
to
c8d2d9f
Compare
Seems like I'll land some test refactors in master that makes conditional parsers easier to do. |
I've rebased this; the ~600 test failures are on node 12 (because it's using typescript-eslint/parser v4 latest instead of v4.0), and node 14+ (because it's using v5). I think we need to update the TS eslint parser in a separate PR, and get those test failures resolved, and then we can rebase this again. |
9cb0129
to
c57701c
Compare
Locally I've got 3 test failures left - 2 are likely a bug in babel's eslint parser, the third is eslint/eslint#15234. |
seems all the tests passed. 🎉 |
@aladdin-add yes, but we're still waiting for eslint-config-airbnb-base to be published, which is blocked on sarbbottam/eslint-find-rules#337. |
2f8b9ac
to
3addf52
Compare
3addf52
to
938704a
Compare
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
eslint-config-airbnb-base
(eslint v8 support airbnb/javascript#2478)v15.0.0
eslint-plugin-eslint-plugin
(Support ESLint 8.x eslint-community/eslint-plugin-eslint-plugin#175)meta.hasSuggestions
property tometa-property-ordering
rule eslint-community/eslint-plugin-eslint-plugin#119v4.0.0-0
v4.0.0
eslint-plugin-import
(Support ESLint 8.x import-js/eslint-plugin-import#2211)v2.25.0
Closes #3055