Remove invalid output tests #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2019-09 and 2020-12 specifications do not require an output unit to be generated for a passing keyword that does not produce an annotation.
|
Thanks for this. I'll have a deeper look tomorrow. For now, I wonder if this is moot. We might be revamping these tests anyway. #657 I would consider these tests as WIP for now (I should update the readme.) |
|
@gregsdennis what's the conclusion on this one? We should probably axe these if they're wrong (which I haven't looked myself), even if we're still redoing the test format. |
gregsdennis
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2019-09 and 2020-12 specifications do not require an output unit to be generated for a passing keyword that does not produce an annotation.