Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test "same $anchor with different base uri" #509

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Add test "same $anchor with different base uri" #509

merged 1 commit into from
Sep 18, 2021

Conversation

santhosh-tekuri
Copy link
Contributor

No description provided.

jdesrosiers
jdesrosiers requested changes Aug 31, 2021
View reviewed changes
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great thing to test. Can you also add it to draft-04, draft-06, draft-07, draft 2019-09, and draft-future.

tests/draft2020-12/anchor.json Outdated Show resolved Hide resolved
tests/draft2020-12/anchor.json Outdated Show resolved Hide resolved
@santhosh-tekuri
Copy link
Contributor Author

santhosh-tekuri commented Sep 1, 2021 •
edited
Loading

added same test to 2019-09, future

karenetheridge
karenetheridge requested changes Sep 2, 2021
View reviewed changes
tests/draft-future/anchor.json Outdated Show resolved Hide resolved
@Julian Julian mentioned this pull request Sep 2, 2021
Closed
@jdesrosiers jdesrosiers merged commit f300dd1 into json-schema-org:master Sep 18, 2021
@Julian Julian mentioned this pull request Jul 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian left review comments

@karenetheridge karenetheridge karenetheridge requested changes

@jdesrosiers jdesrosiers jdesrosiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@santhosh-tekuri @karenetheridge @Julian @jdesrosiers