Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[299, 300] Add tests for invalid use of, and valid use of empty, fragments in "$id" #341

Merged
merged 3 commits into from
May 31, 2020
Merged

[299, 300] Add tests for invalid use of, and valid use of empty, fragments in "$id" #341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59d30e8
[299] Add tests for invalid use of fragments in "$id"
ssilverman Apr 25, 2020
9f54842
[300] Add tests for valid use of empty fragments in "$id"
ssilverman Apr 29, 2020
af3c370
Add unnormalized $id tests
ssilverman May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 206 additions & 0 deletions tests/draft2019-09/id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
[
{
"description": "Invalid use of fragments in location-independent $id",
"schema": {"$ref": "https://json-schema.org/draft/2019-09/schema"},
"tests": [
{
"description": "Identifier name",
"data": {
"$ref": "#foo",
"$defs": {
"A": {
"$id": "#foo",
"type": "integer"
}
}
},
"valid": false
},
{
"description": "Identifier name and no ref",
"data": {
"$defs": {
"A": { "$id": "#foo" }
}
},
"valid": false
},
{
"description": "Identifier path",
"data": {
"$ref": "#/a/b",
"$defs": {
"A": {
"$id": "#/a/b",
"type": "integer"
}
}
},
"valid": false
},
{
"description": "Identifier name with absolute URI",
"data": {
"$ref": "http://localhost:1234/bar#foo",
"$defs": {
"A": {
"$id": "http://localhost:1234/bar#foo",
"type": "integer"
}
}
},
"valid": false
},
{
"description": "Identifier path with absolute URI",
"data": {
"$ref": "http://localhost:1234/bar#/a/b",
"$defs": {
"A": {
"$id": "http://localhost:1234/bar#/a/b",
"type": "integer"
}
}
},
"valid": false
},
{
"description": "Identifier name with base URI change in subschema",
"data": {
"$id": "http://localhost:1234/root",
"$ref": "http://localhost:1234/nested.json#foo",
"$defs": {
"A": {
"$id": "nested.json",
"$defs": {
"B": {
"$id": "#foo",
"type": "integer"
}
}
}
}
},
"valid": false
},
{
"description": "Identifier path with base URI change in subschema",
"data": {
"$id": "http://localhost:1234/root",
"$ref": "http://localhost:1234/nested.json#/a/b",
"$defs": {
"A": {
"$id": "nested.json",
"$defs": {
"B": {
"$id": "#/a/b",
"type": "integer"
}
}
}
}
},
"valid": false
}
]
},
{
"description": "Valid use of empty fragments in location-independent $id",
"comment": "These are allowed but discouraged",
"schema": {
"$ref": "https://json-schema.org/draft/2019-09/schema"
},
"tests": [
{
"description": "Identifier name with absolute URI",
"data": {
"$ref": "http://localhost:1234/bar",
"$defs": {
"A": {
"$id": "http://localhost:1234/bar#",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Identifier name with base URI change in subschema",
"data": {
"$id": "http://localhost:1234/root",
"$ref": "http://localhost:1234/nested.json#/$defs/B",
"$defs": {
"A": {
"$id": "nested.json",
"$defs": {
"B": {
"$id": "#",
"type": "integer"
}
}
}
}
},
"valid": true
}
]
},
{
"description": "Unnormalized $ids are allowed but discouraged",
"schema": {
"$ref": "https://json-schema.org/draft/2019-09/schema"
},
"tests": [
{
"description": "Unnormalized identifier",
"data": {
"$ref": "http://localhost:1234/foo/baz",
"$defs": {
"A": {
"$id": "http://localhost:1234/foo/bar/../baz",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Unnormalized identifier and no ref",
"data": {
"$defs": {
"A": {
"$id": "http://localhost:1234/foo/bar/../baz",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Unnormalized identifier with empty fragment",
"data": {
"$ref": "http://localhost:1234/foo/baz",
"$defs": {
"A": {
"$id": "http://localhost:1234/foo/bar/../baz#",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Unnormalized identifier with empty fragment and no ref",
"data": {
"$defs": {
"A": {
"$id": "http://localhost:1234/foo/bar/../baz#",
"type": "integer"
}
}
},
"valid": true
}
]
}
]