Split format.json, fix relative-json-pointer test #209
Conversation
epoberezkin
force-pushed
the
refactor-format
branch
from
1e959d1
to
f056cb7
Compare
epoberezkin
changed the title
| @@ -13,21 +13,21 @@ const refs = { | |||
|
|
|||
| const SKIP = { | |||
| 4: ['optional/zeroTerminatedFloats'], | |||
| 7: ['optional/content', 'optional/format'] | |||
| 7: [ | |||
| 'format/idn-email', | |||
There was a problem hiding this comment.
Should these be 'optional/format/idn-email' etc., or is it just doing a suffix match? It's mildly confusing for them not to match 'optional/content' etc. but I don't feel strongly about it.
There was a problem hiding this comment.
Yes, that's how the library names the test groups - it uses the two last segments of the path... Just fixed it to match the names with "-".
There was a problem hiding this comment.
Oh, cool, I had not realized that. That's totally fine then, thanks!
|
I'm definitely still OK with this change, but it would be really nice if we hit #53 (at least the ID portion) at some point since this change is kind of backwards incompatible in a way more than it "needs" to be (I mean, it's only being done for Draft 7 here, but in theory it's backwards incompatible if we need to do this again in the future) |
Splits format.json to multiple files - closes #162
Fixes incorrect relative-json-pointer test - closes #208