Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner to the org readme to improve UX #9

Merged
merged 9 commits into from
Jun 30, 2023

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Jun 12, 2023

Add banner to the org readme to improve UX

@benjagm benjagm marked this pull request as draft June 13, 2023 14:28
New banner reviewing the margins
@benjagm benjagm marked this pull request as ready for review June 15, 2023 09:31
@Relequestual
Copy link
Member

I'd like to see the moto use Title Case, but otherwise it look good.

@gregsdennis
Copy link
Member

gregsdennis commented Jun 15, 2023

I'd like to see the moto use Title Case, but otherwise it look good.

I disagree. I like the current casing.

Build more, break less, empower others.

vs

Build More, Break Less, Empower Others.

Maybe just the first word in each phrase, with periods?

Build more. Break less. Empower others.

@Relequestual
Copy link
Member

Maybe just the first word in each phrase, with periods?

Build more. Break less. Empower others.

I think I actually prefer this! Nice! I retract my previous ask for this one.

Added new version of the Banner
Another version of the banner
Banner updated one more time
@benjagm benjagm requested a review from gregsdennis June 21, 2023 17:19
@benjagm
Copy link
Collaborator Author

benjagm commented Jun 21, 2023

@gregsdennis @Relequestual I updated the banner including your comments.

@benjagm benjagm merged commit de70841 into json-schema-org:main Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants