perf(parse): remove additional slice for quoted values #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
reviewed
Oct 1, 2024
| val = val.slice(1, -1) | ||
| } | ||
| var val = (str.charCodeAt(eqIdx) === 0x22) | ||
| ? str.slice(eqIdx + 1, endIdx - 1).trim() |
There was a problem hiding this comment.
I like this change for performance, but I think this changes the behavior. Before it trimmed whitespace around potential quotes, but now it'd trim whitespace within quotes.
|
Going to close this out, I managed to get an extra 10% perf boost across the board by instead iterating using a loop over whitespace (no more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see fastify/fastify-cookie#194 (comment)
Before & after as diff:
https://www.diffchecker.com/hO2It0SH on node v16 (
unquote-> +300 000 op/s)