Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for URL encoded values #48

Closed
wants to merge 1 commit into from

Conversation

andrei-cdl
Copy link

due to a bug in node.js some clients will end up encoding the value
before base64 which results in the incorrect value being parsed.

ref: nodejs/node#31439

due to a bug in node.js some clients will end up encoding the value
before base64 which results in the incorrect value being parsed.
ref: nodejs/node#31439
@andrei-cdl andrei-cdl changed the title feat: add support for URL ecoded values feat: add support for URL encoded values Aug 9, 2021
@dougwilson
Copy link
Contributor

Thank you for this pull request. This is unfortunately not how the header works according to the specification. Doing this would have security implications as clients who follow the spec im combination with this change would allow the username as seen by the client be different as seen by the server, by the nature of the colon separator being hidden in the username.

I'm sure the are various clients who can be buggy; I would suggeset filing an issue with the buggy client so they provide a correctly-formatted header.

@andrei-cdl
Copy link
Author

ah interesting, thanks for looking into it. I didn't realize there would be security implications due to that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants