новое решение sortStrings #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@dosandk) для код-ревью. |
|
Решение было обновлено, посмотрим что скажет @dosandk |
dosandk
reviewed
Jun 23, 2022
| @@ -4,5 +4,16 @@ | |||
| * @returns {function} - function-getter which allow get value from object by set path | |||
| */ | |||
| export function createGetter(path) { | |||
|
|
|||
| const partsArray = path.split("."); | |||
There was a problem hiding this comment.
good 👍 лайк за использование замыкания
dosandk
reviewed
Jun 23, 2022
| let value = {...obj}; | ||
| for (let i = 0; i < partsArray.length; i++) { | ||
| if (typeof value[partsArray[i]] === 'undefined') { | ||
| return undefined; |
There was a problem hiding this comment.
нельзя напрямую возвращать undefined
dosandk
reviewed
Jun 23, 2022
| @@ -4,5 +4,6 @@ | |||
| * @returns {*[]} - the new array with uniq values | |||
| */ | |||
| export function uniq(arr) { | |||
|
|
|||
| const uniq = new Set(arr); | |||
| return Array.from(uniq); | |||
There was a problem hiding this comment.
подумайте какие есть преимущества у Array.from по сравнению с спред-синтаксисом:
return [...new Set(arr)]
There was a problem hiding this comment.
знаю только, что для TypeScript нежелательное использования спред синтаксиса с Set
There was a problem hiding this comment.
@elenakochegina почему нежелательно в TypeScript использовать спред с Set?
There was a problem hiding this comment.
|
Добавляю преподавателя (@dosandk) для код-ревью. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.