Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.js.org #9211

Merged
merged 1 commit into from
Aug 25, 2024
Merged

go.js.org #9211

merged 1 commit into from
Aug 25, 2024

Conversation

simonsarris
Copy link
Contributor

This will have go.js.org go to an info site for the GoJS diagramming library. I am modeling this after the vue.js.org example.

@MattIPv4 MattIPv4 changed the title Update cnames_active.js add "go" go.js.org Aug 22, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Aug 22, 2024
@simonsarris
Copy link
Contributor Author

Whoops, I just set the CNAME file correctly.

However, in the GH repo settings if I set go.js.org as the custom domain it will complain:

"The custom domain go.js.org is already taken. If you are the owner of this domain..."

@MattIPv4
Copy link
Member

Ah, that's unfortunate. You'll need to reach out to GitHub support I believe to ask them to release the subdomain for you to use (someone else has it configured in their project when they haven't requested it here).

@simonsarris
Copy link
Contributor Author

It looks like GH would want me to add a DNS txt record, which I would need your cooperation for.

If that's too onerous, I could easily switch the PR to use diagram.js.org, which I was considering instead.

@MattIPv4
Copy link
Member

@indus should be able to add the TXT record if you can share it here

@simonsarris
Copy link
Contributor Author

Sure thing:

TXT record for the following hostname: _github-pages-challenge-simonsarris.go.js.org

TXT record value: 676c0208bba70eb488443fa745f168

@indus
Copy link
Member

indus commented Aug 23, 2024

I've just added the TXT record (as well as the CNAME). Please keep this open. I will merge when your page is up and running.

@simonsarris
Copy link
Contributor Author

@indus I am very sorry for the trouble, but it is still complaining that I do not own the domain. This is probably due to the ownership of the repo being NorthwoodsSoftware and not my personal account. Could you replace the record with:

TXT record _github-pages-challenge-NorthwoodsSoftware.go.js.org
TXT record value: 4a139a07d2633cca16ce9cb71b0a20

If that fails, I'll have to contact Github. I should have noticed sooner that there was a settings context for the organization that I could have used instead.

@indus
Copy link
Member

indus commented Aug 24, 2024

@simonsarris No problem. I've just replaced it.

@simonsarris
Copy link
Contributor Author

Thank you, it looks like its working at last.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Aug 25, 2024
@indus
Copy link
Member

indus commented Aug 25, 2024

Welcome https://go.js.org

@indus indus merged commit 0c91ef5 into js-org:master Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants