Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to save Optimizer in the save method #220

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Option to save Optimizer in the save method #220

merged 9 commits into from
Jul 23, 2024

Conversation

jrzaurin
Copy link
Owner

Simple adjustment to add the option to save the optimizer when using the Trainer's save method

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 58.16327% with 41 lines in your changes missing coverage. Please review.

Project coverage is 93.94%. Comparing base (8057360) to head (5b4bd9e).

Files Patch % Lines
...ed_training/_base_contrastive_denoising_trainer.py 48.64% 19 Missing ⚠️
...pervised_training/_base_encoder_decoder_trainer.py 17.39% 19 Missing ⚠️
pytorch_widedeep/training/_base_trainer.py 90.47% 2 Missing ⚠️
pytorch_widedeep/training/trainer.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   94.38%   93.94%   -0.44%     
==========================================
  Files         117      117              
  Lines        7445     7504      +59     
==========================================
+ Hits         7027     7050      +23     
- Misses        418      454      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrzaurin jrzaurin merged commit deb4f2e into master Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant