fix: make implicit relationship teardown following delete of related …

…record safe (emberjs#8705)
jrjohnson · Jul 28, 2023 · 4bbc173 · 4bbc173
1 parent 02db7e0
commit 4bbc173
Show file tree

Hide file tree

Showing 2 changed files with 1,099 additions and 0 deletions.
diff --git a/packages/graph/src/-private/graph/graph.ts b/packages/graph/src/-private/graph/graph.ts
@@ -206,6 +206,11 @@ export class Graph {
     const keys = Object.keys(relationships);
     for (let i = 0; i < keys.length; i++) {
       const relationship: RelationshipEdge = relationships[keys[i]];
+      // account for previously unloaded relationships
+      // typically from a prior deletion of a record that pointed to this one implicitly
+      if (relationship === undefined) {
+        continue;
+      }
       assert(`Expected a relationship`, relationship);
       if (relationship.definition.inverseIsAsync) {
         return false;